Control-Structure Issues


  • Do expressions use True and False rather than 1 and 0?
  • Are boolean values compared to False implicitly?
  • Have boolean expressions been simplified by using additional boolean variables, boolean functions, and decision tables?
  • Are expressions stated positively?
  • In C, are numbers, characters, and pointers compared to 0 explicitly?
  • Do begin/end pairs balance?
  • Are begin/end pairs used everywhere they're needed for clarity?
  • Are null statements obvious?
  • Have nested statements been simplified by retesting part of the conditional, converting to if-then-elses, or moving nested code into its own routine?
  • If the routine has a decision count of more than 10, is there a good reason for not redesigning it?